[libc-commits] [PATCH] D144803: [libc] Fix mismatch in exception decl

[Jeff Bailey via Phabricator via libc-commits]

jeffbailey created this revision.
Herald added subscribers: libc-commits, ecnelises, tschuett.
Herald added projects: libc-project, All.
jeffbailey requested review of this revision.

When running the libc tests under vscode, I got an error about a
mismatches exception declaration for strerror.  Since string.h
seems to be getting included transitively anyway, just include
it and rely on its definition.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D144803

Files:
  libc/test/ErrnoSetterMatcher.h


Index: libc/test/ErrnoSetterMatcher.h
===================================================================
--- libc/test/ErrnoSetterMatcher.h
+++ libc/test/ErrnoSetterMatcher.h
@@ -12,14 +12,13 @@
 #include "test/UnitTest/Test.h"
 
 #include <errno.h>
+#include <string.h>
 
 namespace __llvm_libc {
 namespace testing {
 
 namespace internal {
 
-extern "C" char *strerror(int);
-
 template <typename T> class ErrnoSetterMatcher : public Matcher<T> {
   T ExpectedReturn;
   T ActualReturn;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144803.500485.patch
Type: text/x-patch
Size: 491 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230226/9d818882/attachment.bin>