[libc-commits] [PATCH] D144340: [libc][math] Set floating point exceptions for exp*f, sinhf, and coshf.

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.


================
Comment at: libc/src/__support/FPUtil/FEnvImpl.h:52
 
+namespace __llvm_libc::fputil {
+
----------------
The utils here are what I would view as "only if required" utils to be employed just before returning from a public function. So, I would prefer if they live in the `src/math` directory, much like https://github.com/llvm/llvm-project/blob/main/libc/src/math/generic/math_utils.h#L53. At some point they should be unified.


================
Comment at: libc/src/__support/FPUtil/FEnvImpl.h:55
+LIBC_INLINE int set_except_if_required(int excepts) {
+  if (math_errhandling & MATH_ERREXCEPT)
+    return set_except(excepts);
----------------
`if constexpr (...)` here and below?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144340/new/

https://reviews.llvm.org/D144340