[libc-commits] [PATCH] D144679: [libc] Clarify printf percent conversion behavior.

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/src/stdio/printf_core/parser.cpp:112
+      // says that "If a conversion specification is invalid, the behavior is
+      // undefined." Based on that I define that any conversion specification
+      // ending in '%' shall display as '%' regardless of any valid or invalid
----------------
lntue wrote:
> Probably we should have a section in the main doc page about `implementation-defined behaviors and rationale`, with links to the implementations and tests.
Address this before landing: Please use "we" instead of "I".

Can be done as a follow up step: +1 for adding a doc page titled "Implementation Defined Behavior".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144679/new/

https://reviews.llvm.org/D144679