[libc-commits] [PATCH] D144663: [libc] Introduce a target named libc-unit-tests to run just the unit tests.

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Feb 23 11:33:08 PST 2023


sivachandra created this revision.
sivachandra added reviewers: lntue, michaelrj, jhuber6.
Herald added subscribers: libc-commits, ecnelises, tschuett.
Herald added projects: libc-project, All.
sivachandra requested review of this revision.

The target "check-libc" now runs all enabled tests which, depending on
the build mode, includes the unit tests, the integration tests and the api
test.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D144663

Files:
  libc/cmake/modules/LLVMLibCTestRules.cmake
  libc/test/CMakeLists.txt
  libc/test/integration/CMakeLists.txt
  libc/test/src/CMakeLists.txt


Index: libc/test/src/CMakeLists.txt
===================================================================
--- libc/test/src/CMakeLists.txt
+++ libc/test/src/CMakeLists.txt
@@ -97,6 +97,8 @@
 )
 
 add_custom_target(libc-api-test)
+add_dependencies(check-libc libc-api-test)
+
 set(
   allocator_entrypoints 
     libc.src.stdlib.malloc
Index: libc/test/integration/CMakeLists.txt
===================================================================
--- libc/test/integration/CMakeLists.txt
+++ libc/test/integration/CMakeLists.txt
@@ -1,4 +1,5 @@
 add_custom_target(libc-integration-tests)
+add_dependencies(check-libc libc-integration-tests)
 
 function(add_libc_integration_test_suite name)
   add_custom_target(${name})
Index: libc/test/CMakeLists.txt
===================================================================
--- libc/test/CMakeLists.txt
+++ libc/test/CMakeLists.txt
@@ -12,8 +12,8 @@
 )
 
 add_custom_target(check-libc)
-add_custom_target(check-llvmlibc)
-add_dependencies(check-libc check-llvmlibc)
+add_custom_target(libc-unit-tests)
+add_dependencies(check-libc libc-unit-tests)
 
 add_custom_target(exhaustive-check-libc)
 add_custom_target(libc-long-running-tests)
Index: libc/cmake/modules/LLVMLibCTestRules.cmake
===================================================================
--- libc/cmake/modules/LLVMLibCTestRules.cmake
+++ libc/cmake/modules/LLVMLibCTestRules.cmake
@@ -300,7 +300,7 @@
 
 function(add_libc_testsuite suite_name)
   add_custom_target(${suite_name})
-  add_dependencies(check-llvmlibc ${suite_name})
+  add_dependencies(libc-unit-tests ${suite_name})
 endfunction(add_libc_testsuite)
 
 function(add_libc_exhaustive_testsuite suite_name)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144663.499928.patch
Type: text/x-patch
Size: 1680 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230223/d9d4bfb8/attachment.bin>


More information about the libc-commits mailing list