[libc-commits] [PATCH] D144415: [libc] Introduce sys/socket.h

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added a comment.
This revision is now accepted and ready to land.

LGTM but added an inline comment asking to add some documentation.



================
Comment at: libc/include/llvm-libc-macros/linux/sys-socket-macros.h:12
+
+#define AF_UNSPEC 0
+#define AF_UNIX 1
----------------
Add a comment (against each constant) explaining:

1. What they indicate
2. How you arrived at the value. It can be something simple like, "Value specified by POSIX", or "Value matches Linux definition from <linux header>".
3. Which standard or extension specifies/requires the definition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144415/new/

https://reviews.llvm.org/D144415