[libc-commits] [PATCH] D144357: [libc] Add Month enum, refactor mktime_test

Jeff Bailey via Phabricator via libc-commits libc-commits at lists.llvm.org
Sun Feb 19 19:59:47 PST 2023


jeffbailey created this revision.
jeffbailey added a reviewer: rtenneti.
Herald added subscribers: libc-commits, ecnelises, tschuett.
Herald added projects: libc-project, All.
jeffbailey requested review of this revision.

Introduce Month enum.

Use designated initializers instead of comments to ensure that tm_data
is initialized correctly.  Use Month enum for initializing .tm_mon to
avoid off-by-one errors.

Co-authored-by: Raman Tenneti <rtenneti at google.com>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D144357

Files:
  libc/src/time/time_utils.h
  libc/test/src/time/mktime_test.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144357.498712.patch
Type: text/x-patch
Size: 31829 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230220/8845b889/attachment-0001.bin>


More information about the libc-commits mailing list