[libc-commits] [PATCH] D143913: [libc][NFC] Make tuning macros start with LIBC_COPT_

Tue Feb 14 04:07:58 PST 2023

gchatelet marked an inline comment as done.
gchatelet added a comment.

@phosek @mcgrathr this patch would also rename `LLVM_LIBC_TEST_USE_FUCHSIA` to `LIBC_COPT_TEST_USE_FUCHSIA` to conform to our guidelines.
Let me know if that's an issue for you.

================
Comment at: libc/test/src/math/RoundToIntegerTest.h:89
+    // is not forwarded to C++.
 #if LLVM_LIBC_IMPLEMENTATION_DEFINED_TEST_BEHAVIOR
     // Result is not well-defined, we always returns INTEGER_MAX
----------------
lntue wrote:
> gchatelet wrote:
> > @lntue I'm unsure what this is about so I didn't rename it. Is it supposed to be exposed at some point?
> > There is a [CMake option here](https://github.com/llvm/llvm-project/blob/95526930da6c00f6f12816d1f99bdf99980c387f/libc/CMakeLists.txt#L68) but it is not sufficient to pass the option down to the C++ code.
> I think we planned to have a section on the documentations about all the implementation-defined cases where we are different from glibc and maybe provide these flags for users.
So IIUC this is a customization point and it should be renamed.
I'll do so, let me know if you think otherwise.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143913/new/

https://reviews.llvm.org/D143913