[libc-commits] [PATCH] D143627: [libc] Run libc tests unconditionally, even if there are no source changes.

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/cmake/modules/LLVMLibCTestRules.cmake:132-136
+  if(NOT LIBC_UNITTEST_NO_RUN_POSTBUILD)
+    set(fq_build_target_name ${fq_target_name}.__build__)
+  else()
+    set(fq_build_target_name ${fq_target_name})
+  endif()
----------------
gchatelet wrote:
> How about removing the NOT and swapping the two blocks? The condition is already a double negation.
> 
> Actually, how about renaming the CMake variable into `LIBC_UNITTEST_RUN_POSTBUILD`?
I have reversed the conditional but kept the name as is as it a optional argument to the function. So, it is `OFF` by default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143627/new/

https://reviews.llvm.org/D143627