[libc-commits] [PATCH] D139839: [libc] Add a loader utility for AMDHSA architectures for testing

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Feb 9 05:01:15 PST 2023


jhuber6 added inline comments.


================
Comment at: libc/utils/gpu/loader/amdgpu/CMakeLists.txt:4
+  PRIVATE
+  hsa-runtime64::hsa-runtime64
+  gpu_loader
----------------
sivachandra wrote:
> How does this get discovered?
```
find_package(hsa-runtime64 QUIET 1.2.0 HINTS ${CMAKE_INSTALL_PREFIX} PATHS /opt/rocm)
if(hsa-runtime64_FOUND)
  add_subdirectory(amdgpu)
endif()
```
>From this code in the base loader, we'll need to add a check to only enable tests if the user has a GPU set and the ability to build something to launch it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139839/new/

https://reviews.llvm.org/D139839



More information about the libc-commits mailing list