[libc-commits] [libc] 6c7e047 - [libc] Fix pthread argument for scudo integration tests when using GCC

[David Spickett via libc-commits]

Author: David Spickett
Date: 2023-02-06T09:49:57Z
New Revision: 6c7e047b40613729a6fe250d9997d86a04f0e000

URL: https://github.com/llvm/llvm-project/commit/6c7e047b40613729a6fe250d9997d86a04f0e000
DIFF: https://github.com/llvm/llvm-project/commit/6c7e047b40613729a6fe250d9997d86a04f0e000.diff

LOG: [libc] Fix pthread argument for scudo integration tests when using GCC

This adds "-pthreads" which appears to be a clang only
alias for "-pthread" (all the drivers check for both).

Use "-pthread" instead to be compatible with gcc.

Otherwise you get:
FAILED: bin/libc-gwp-asan-uaf-should-crash
: && /usr/bin/g++-11 <...> -pthreads <...> projects/libc/test/integration/scudo/liblibc_for_scudo_integration_test.a && :
g++-11: error: unrecognized command-line option ‘-pthreads’; did you mean ‘-pthread’?

Reviewed By: michaelrj

Differential Revision: https://reviews.llvm.org/D143258

Added: 
    

Modified: 
    libc/test/integration/scudo/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/libc/test/integration/scudo/CMakeLists.txt b/libc/test/integration/scudo/CMakeLists.txt
index ca3e2c83e5131..4fb8b656f89c9 100644
--- a/libc/test/integration/scudo/CMakeLists.txt
+++ b/libc/test/integration/scudo/CMakeLists.txt
@@ -27,7 +27,7 @@ add_executable(
 target_link_options(
   libc-scudo-integration-test
   PRIVATE
-  -pthreads
+  -pthread
 )
 
 target_link_libraries(libc-scudo-integration-test
@@ -43,7 +43,7 @@ add_executable(
 target_link_options(
   libc-gwp-asan-uaf-should-crash
   PRIVATE
-  -pthreads
+  -pthread
 )
 
 target_link_libraries(libc-gwp-asan-uaf-should-crash