[libc-commits] [PATCH] D143006: [libc] add printf auto float conversion

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/test/src/stdio/sprintf_test.cpp:2121
+
+  // TODO: Fix long doubles (needs bigger table or alternate algorithm.)
+  // Currently the table values are generated, which is very slow.
----------------
Does this TODO belong here or somewhere in the implementation?


================
Comment at: libc/test/src/stdio/sprintf_test.cpp:2398
+
+  /*
+    written = __llvm_libc::sprintf(buff, "%.1La", 0.1L);
----------------
Please add a comment explaining why we have these commented out blocks.


================
Comment at: libc/test/src/stdio/sprintf_test.cpp:2696
+  // written = __llvm_libc::sprintf(buff, "abc123%n", nullptr);
+  // EXPECT_LT(written, 0);
 }
----------------
Why is this commented out?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143006/new/

https://reviews.llvm.org/D143006