[libc-commits] [libc] 008acfb - [libc] Fix quotation marks in overlay mode instructions

[David Spickett via libc-commits]

Author: David Spickett
Date: 2023-02-03T14:44:40Z
New Revision: 008acfb519510abe37468bd26f635c8d817b6067

URL: https://github.com/llvm/llvm-project/commit/008acfb519510abe37468bd26f635c8d817b6067
DIFF: https://github.com/llvm/llvm-project/commit/008acfb519510abe37468bd26f635c8d817b6067.diff

LOG: [libc] Fix quotation marks in overlay mode instructions

These were using ” ("right double quotation mark") instead of
the usual ". This means CMake took the value literally and you
got:
```
CMake Error at CMakeLists.txt:139 (MESSAGE):
  ”libc” isn't a known project:
  bolt;clang;clang-tools-extra;compiler-rt;cross-project-tests;libc;libclc;lld;lldb;mlir;openmp;polly;pstl;flang.
  Did you mean to enable it as a runtime in LLVM_ENABLE_RUNTIMES?
```
`="libc"` works fine.

Reviewed By: lntue

Differential Revision: https://reviews.llvm.org/D143254

Added: 
    

Modified: 
    libc/docs/overlay_mode.rst

Removed: 
    


################################################################################
diff  --git a/libc/docs/overlay_mode.rst b/libc/docs/overlay_mode.rst
index 0039e67f6384e..c0f4d896ff961 100644
--- a/libc/docs/overlay_mode.rst
+++ b/libc/docs/overlay_mode.rst
@@ -39,7 +39,7 @@ the CMake configure step as follows:
   $> cd llvm-project  # The llvm-project checkout
   $> mkdir build
   $> cd build
-  $> cmake ../llvm -G Ninja -DLLVM_ENABLE_PROJECTS=”libc”  \
+  $> cmake ../llvm -G Ninja -DLLVM_ENABLE_PROJECTS="libc"  \
      -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ \
      -DCMAKE_BUILD_TYPE=<Debug|Release>                    \  # Select build type
      -DCMAKE_INSTALL_PREFIX=<Your prefix of choice>           # Optional
@@ -71,8 +71,8 @@ appropriately:
 
 .. code-block:: sh
 
-  $> cmake ../llvm -G Ninja -DLLVM_ENABLE_PROJECTS=”clang” \
-     -DLLVM_ENABLE_RUNTIMES=”libc”  \  # libc is listed as runtime and not as a project
+  $> cmake ../llvm -G Ninja -DLLVM_ENABLE_PROJECTS="clang" \
+     -DLLVM_ENABLE_RUNTIMES="libc"  \  # libc is listed as runtime and not as a project
      -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ \
      -DCMAKE_BUILD_TYPE=<Debug|Release>                    \  # Select build type
      -DCMAKE_INSTALL_PREFIX=<Your prefix of choice>           # Optional