[libc-commits] [PATCH] D143261: [libc][AArch64] Fix fullbuild when using G++/GCC

[David Spickett via Phabricator via libc-commits]

DavidSpickett added a comment.

I don't know what your policies on defines by compiler are, but this passes all tests on AArch64 Linux building with gcc 11.

If you don't want them then I'll instead note in the documentation that gcc is not supported for AArch64 for these reasons.



================
Comment at: libc/src/__support/threads/linux/thread.cpp:221
+#else
+    asm volatile("mov x29, sp");
+#endif
----------------
This I maybe don't need volatile and might need to describe the side effects? If you're ok with inline asm here in general, I'll check if I need those.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143261/new/

https://reviews.llvm.org/D143261