[libc-commits] [PATCH] D143258: [libc] Fix pthread argument for scudo integration tests when using GCC

[David Spickett via Phabricator via libc-commits]

DavidSpickett created this revision.
Herald added subscribers: libc-commits, yaneury, supersymetrie, Chia-hungDuan, ecnelises, tschuett, cryptoad.
Herald added projects: libc-project, All.
DavidSpickett requested review of this revision.

This adds "-pthreads" which appears to be a clang only
alias for "-pthread" (all the drivers check for both).

Use "-pthread" instead to be compatible with gcc.

Otherwise you get:
FAILED: bin/libc-gwp-asan-uaf-should-crash
: && /usr/bin/g++-11 <...> -pthreads <...> projects/libc/test/integration/scudo/liblibc_for_scudo_integration_test.a && :
g++-11: error: unrecognized command-line option ‘-pthreads’; did you mean ‘-pthread’?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143258

Files:
  libc/test/integration/scudo/CMakeLists.txt


Index: libc/test/integration/scudo/CMakeLists.txt
===================================================================
--- libc/test/integration/scudo/CMakeLists.txt
+++ libc/test/integration/scudo/CMakeLists.txt
@@ -27,7 +27,7 @@
 target_link_options(
   libc-scudo-integration-test
   PRIVATE
-  -pthreads
+  -pthread
 )
 
 target_link_libraries(libc-scudo-integration-test
@@ -43,7 +43,7 @@
 target_link_options(
   libc-gwp-asan-uaf-should-crash
   PRIVATE
-  -pthreads
+  -pthread
 )
 
 target_link_libraries(libc-gwp-asan-uaf-should-crash


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143258.494574.patch
Type: text/x-patch
Size: 544 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230203/6fb0b88d/attachment.bin>