[libc-commits] [PATCH] D143254: [libc] Fix quotation marks in overlay mode instructions

[David Spickett via Phabricator via libc-commits]

DavidSpickett created this revision.
Herald added a reviewer: bollu.
Herald added subscribers: libc-commits, bzcheeseman, ecnelises, rriddle, tschuett.
Herald added projects: libc-project, All.
DavidSpickett requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: sstefan1, stephenneuendorffer.

These were using ” ("right double quotation mark") instead of
the usual ". This means CMake took the value literally and you
got:

CMake Error at CMakeLists.txt:139 (MESSAGE):

  ”libc” isn't a known project:
  bolt;clang;clang-tools-extra;compiler-rt;cross-project-tests;libc;libclc;lld;lldb;mlir;openmp;polly;pstl;flang.
  Did you mean to enable it as a runtime in LLVM_ENABLE_RUNTIMES?

"libc" works fine.
==================


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D143254

Files:
  libc/docs/overlay_mode.rst


Index: libc/docs/overlay_mode.rst
===================================================================
--- libc/docs/overlay_mode.rst
+++ libc/docs/overlay_mode.rst
@@ -39,7 +39,7 @@
   $> cd llvm-project  # The llvm-project checkout
   $> mkdir build
   $> cd build
-  $> cmake ../llvm -G Ninja -DLLVM_ENABLE_PROJECTS=”libc”  \
+  $> cmake ../llvm -G Ninja -DLLVM_ENABLE_PROJECTS="libc"  \
      -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ \
      -DCMAKE_BUILD_TYPE=<Debug|Release>                    \  # Select build type
      -DCMAKE_INSTALL_PREFIX=<Your prefix of choice>           # Optional
@@ -71,8 +71,8 @@
 
 .. code-block:: sh
 
-  $> cmake ../llvm -G Ninja -DLLVM_ENABLE_PROJECTS=”clang” \
-     -DLLVM_ENABLE_RUNTIMES=”libc”  \  # libc is listed as runtime and not as a project
+  $> cmake ../llvm -G Ninja -DLLVM_ENABLE_PROJECTS="clang" \
+     -DLLVM_ENABLE_RUNTIMES="libc"  \  # libc is listed as runtime and not as a project
      -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ \
      -DCMAKE_BUILD_TYPE=<Debug|Release>                    \  # Select build type
      -DCMAKE_INSTALL_PREFIX=<Your prefix of choice>           # Optional


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143254.494564.patch
Type: text/x-patch
Size: 1184 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230203/22e9417b/attachment-0001.bin>