[libc-commits] [PATCH] D143098: [libc][math] Fix setting exceptional value for tanf to work with gcc.
Siva Chandra via Phabricator via libc-commits
libc-commits at lists.llvm.org
Wed Feb 1 11:33:36 PST 2023
sivachandra added inline comments.
================
Comment at: libc/src/math/generic/tanf.cpp:100
- return fputil::multiply_add(sign, 0x1.ddf9f4p0f, sign * 0x1.1p-24f);
+ volatile float tmp = 0x1.ddf9f4p0f;
+ tmp = fputil::multiply_add(sign, tmp, sign * 0x1.1p-24f);
----------------
Can you add some commentary to explain why a volatile is required?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143098/new/
https://reviews.llvm.org/D143098
More information about the libc-commits
mailing list