[libc-commits] [libc] [libc] major refactor of startup library (PR #76092)

via libc-commits libc-commits at lists.llvm.org
Thu Dec 21 15:56:50 PST 2023


================
@@ -223,7 +19,7 @@ extern "C" void _start() {
   // will take us to the previous stack pointer. That is the reason why the
   // actual business logic of the startup code is pushed into a non-inline
   // function do_start so that this function is free of any stack usage.
-  app.args = reinterpret_cast<LIBC_NAMESPACE::Args *>(
+  app.args = reinterpret_cast<Args *>(
----------------
michaelrj-google wrote:

nit: given that the namespace is only used twice, it's probably better to do `LIBC_NAMESPACE::Args` and `LIBC_NAMESPACE::do_start` instead of a `using` at the start

https://github.com/llvm/llvm-project/pull/76092


More information about the libc-commits mailing list