[libc-commits] [libc] [libc][NFC] Rename `MANTISSA_WIDTH` in `FRACTION_BITS` (PR #75489)

Guillaume Chatelet via libc-commits libc-commits at lists.llvm.org
Thu Dec 14 08:24:54 PST 2023


================
@@ -33,37 +33,37 @@ template <> struct FPBits<long double> : private FloatProperties<long double> {
   using FloatProperties<long double>::EXPONENT_MASK;
   using FloatProperties<long double>::EXPONENT_BIAS;
   using FloatProperties<long double>::EXPONENT_WIDTH;
-  using FloatProperties<long double>::MANTISSA_MASK;
-  using FloatProperties<long double>::MANTISSA_WIDTH;
+  using FloatProperties<long double>::FRACTION_MASK;
+  using FloatProperties<long double>::FRACTION_BITS;
----------------
gchatelet wrote:

I'm willing to change them to:
 - `EXPONENT_WIDTH` => `EXP_BITS` - or `EXPONENT_BITS` if you prefer
 - `BIT_WIDTH` => `TOTAL_BITS` - or any other suggestions, I initially thought about `FP_BITS` but @michaelrj-google rightfully suggested that it would conflict with the `FPBits` class.

I can do the modification as part of this patch or in another one if you prefer, let me know.

https://github.com/llvm/llvm-project/pull/75489


More information about the libc-commits mailing list