[libc-commits] [libc] ac640c6 - [libc][math] Ensure fputil::nextafter is called with correct type args (#75009)

[via libc-commits]

Author: Nishant Mittal
Date: 2023-12-10T15:48:31-05:00
New Revision: ac640c627c4ed4a9a89cb57f3f661c25bf38ed07

URL: https://github.com/llvm/llvm-project/commit/ac640c627c4ed4a9a89cb57f3f661c25bf38ed07
DIFF: https://github.com/llvm/llvm-project/commit/ac640c627c4ed4a9a89cb57f3f661c25bf38ed07.diff

LOG: [libc][math] Ensure fputil::nextafter is called with correct type args (#75009)

Follow up to
https://github.com/llvm/llvm-project/pull/73698#discussion_r1411134482

Added: 
    

Modified: 
    libc/src/__support/FPUtil/ManipulationFunctions.h

Removed: 
    


################################################################################
diff  --git a/libc/src/__support/FPUtil/ManipulationFunctions.h b/libc/src/__support/FPUtil/ManipulationFunctions.h
index 9d3fd075be4711..08adb074b121fa 100644
--- a/libc/src/__support/FPUtil/ManipulationFunctions.h
+++ b/libc/src/__support/FPUtil/ManipulationFunctions.h
@@ -144,10 +144,11 @@ LIBC_INLINE T ldexp(T x, int exp) {
   return normal;
 }
 
-template <
-    typename T, typename U,
-    cpp::enable_if_t<cpp::is_floating_point_v<T> && cpp::is_floating_point_v<U>,
-                     int> = 0>
+template <typename T, typename U,
+          cpp::enable_if_t<cpp::is_floating_point_v<T> &&
+                               cpp::is_floating_point_v<U> &&
+                               (sizeof(T) <= sizeof(U)),
+                           int> = 0>
 LIBC_INLINE T nextafter(T from, U to) {
   FPBits<T> from_bits(from);
   if (from_bits.is_nan())
@@ -157,6 +158,9 @@ LIBC_INLINE T nextafter(T from, U to) {
   if (to_bits.is_nan())
     return static_cast<T>(to);
 
+  // NOTE: This would work only if `U` has a greater or equal precision than
+  // `T`. Otherwise `from` could loose its precision and the following statement
+  // could incorrectly evaluate to `true`.
   if (static_cast<U>(from) == to)
     return static_cast<T>(to);