[libc-commits] [libc] [libc][NFC] Remove custom leading_zeroes, factor in frequent typenames (PR #74825)

via libc-commits libc-commits at lists.llvm.org
Fri Dec 8 11:20:32 PST 2023


================
@@ -150,9 +111,7 @@ eisel_lemire(ExpandedFloat<T> init_num,
   // accuracy, and the most significant bit is ignored.) = 9 bits. Similarly,
   // it's 6 bits for floats in this case.
   const uint64_t halfway_constant =
-      (uint64_t(1) << (BITS_IN_MANTISSA -
-                       fputil::FloatProperties<T>::MANTISSA_WIDTH - 3)) -
-      1;
+      (uint64_t(1) << (BITS_IN_MANTISSA - FloatProp::MANTISSA_WIDTH - 3)) - 1;
----------------
michaelrj-google wrote:

given the other places where this is changed to `BITS_IN_MANTISSA - (FloatProp::MANTISSA_WIDTH + 3)` this should probably be changed to match.

https://github.com/llvm/llvm-project/pull/74825


More information about the libc-commits mailing list