[libc-commits] [libc] [libc][NFC] Remove custom leading_zeroes, factor in frequent typenames (PR #74825)

Guillaume Chatelet via libc-commits libc-commits at lists.llvm.org
Fri Dec 8 03:25:13 PST 2023


gchatelet wrote:

I've also used `UIntType` instead of `BitsType`. Both are in use in the code base `FloatProperties` uses `BitsType` and `FPBits` uses `UIntType`. I don't think we need both as they really are the same type.

Would that make sense to also factor in some code dealing with `MANTISSA_WIDTH`? I see a few subtractions and additions with `1`, `2` or `3`, but it's not always clear what that means. Would it be more appropriate to use `MANTISSA_PRECISION` instead of `MANTISSA_WIDTH` in some of these lines?

https://github.com/llvm/llvm-project/pull/74825


More information about the libc-commits mailing list