[libc-commits] [libc] a28e4ea - [libc] Default to a single threaded thread pool for GPU tests (#74486)

[via libc-commits]

Author: Joseph Huber
Date: 2023-12-05T15:25:50Z
New Revision: a28e4eac26ccd2e17f041b8d96da93df4a2414c0

URL: https://github.com/llvm/llvm-project/commit/a28e4eac26ccd2e17f041b8d96da93df4a2414c0
DIFF: https://github.com/llvm/llvm-project/commit/a28e4eac26ccd2e17f041b8d96da93df4a2414c0.diff

LOG: [libc] Default to a single threaded thread pool for GPU tests (#74486)

Summary:
The GPU tests tend to fail when run massively in parallel. This is why
we use a CMake job pool to limit it to 1 in most cases. We should
default to the configuration that is most likely to work, that being a
single thread. There aren't enough GPU tests for this to be a massive
increase in test time on the bots, so we should default to what works
guaranteed.

Added: 
    

Modified: 
    libc/cmake/modules/prepare_libc_gpu_build.cmake

Removed: 
    


################################################################################
diff  --git a/libc/cmake/modules/prepare_libc_gpu_build.cmake b/libc/cmake/modules/prepare_libc_gpu_build.cmake
index 377bc4eeae8fc..f3ccbdc9eb15a 100644
--- a/libc/cmake/modules/prepare_libc_gpu_build.cmake
+++ b/libc/cmake/modules/prepare_libc_gpu_build.cmake
@@ -78,6 +78,9 @@ set(LIBC_GPU_TEST_JOBS "" CACHE STRING "Number of jobs to use for GPU tests")
 if(LIBC_GPU_TEST_JOBS)
   set_property(GLOBAL PROPERTY JOB_POOLS LIBC_GPU_TEST_POOL=${LIBC_GPU_TEST_JOBS})
   set(LIBC_HERMETIC_TEST_JOB_POOL JOB_POOL LIBC_GPU_TEST_POOL)
+else()
+  set_property(GLOBAL PROPERTY JOB_POOLS LIBC_GPU_TEST_POOL=1)
+  set(LIBC_HERMETIC_TEST_JOB_POOL JOB_POOL LIBC_GPU_TEST_POOL)
 endif()
 
 set(LIBC_GPU_TEST_ARCHITECTURE "" CACHE STRING "Architecture for the GPU tests")