[libc-commits] [libc] [libc] Fix arm32 tests (PR #74457)
via libc-commits
libc-commits at lists.llvm.org
Tue Dec 5 04:18:03 PST 2023
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libc
Author: Guillaume Chatelet (gchatelet)
<details>
<summary>Changes</summary>
`ASSERT_EQ` requires that both operands have the same type but on arm32 `size_t` is `unsigned int` instead of `unsigned long`. Using `size_t` explicitely to avoid "conflicting types for parameter 'ValType'"
---
Full diff: https://github.com/llvm/llvm-project/pull/74457.diff
1 Files Affected:
- (modified) libc/test/src/__support/memory_size_test.cpp (+6-6)
``````````diff
diff --git a/libc/test/src/__support/memory_size_test.cpp b/libc/test/src/__support/memory_size_test.cpp
index 3cfddeb499d48..80cb195185126 100644
--- a/libc/test/src/__support/memory_size_test.cpp
+++ b/libc/test/src/__support/memory_size_test.cpp
@@ -83,13 +83,13 @@ TEST(LlvmLibcMemSizeTest, AlignUp) {
}
TEST(LlvmLibcBlockBitTest, OffsetTo) {
- ASSERT_EQ(SafeMemSize::offset_to(0, 512), 0UL);
- ASSERT_EQ(SafeMemSize::offset_to(1, 512), 511UL);
- ASSERT_EQ(SafeMemSize::offset_to(2, 512), 510UL);
- ASSERT_EQ(SafeMemSize::offset_to(13, 1), 0UL);
- ASSERT_EQ(SafeMemSize::offset_to(13, 4), 3UL);
+ ASSERT_EQ(SafeMemSize::offset_to(0, 512), size_t(0));
+ ASSERT_EQ(SafeMemSize::offset_to(1, 512), size_t(511));
+ ASSERT_EQ(SafeMemSize::offset_to(2, 512), size_t(510));
+ ASSERT_EQ(SafeMemSize::offset_to(13, 1), size_t(0));
+ ASSERT_EQ(SafeMemSize::offset_to(13, 4), size_t(3));
for (unsigned int i = 0; i < 31; ++i) {
- ASSERT_EQ((SafeMemSize::offset_to(i, 1u << i) + i) % (1u << i), 0UL);
+ ASSERT_EQ((SafeMemSize::offset_to(i, 1u << i) + i) % (1u << i), size_t(0));
}
}
} // namespace internal
``````````
</details>
https://github.com/llvm/llvm-project/pull/74457
More information about the libc-commits
mailing list