[libc-commits] [llvm] [libc] [libc][NFC] Fix missing LIBC_INLINE + style (PR #73659)

Roland McGrath via libc-commits libc-commits at lists.llvm.org
Mon Dec 4 17:41:10 PST 2023


================
@@ -24,74 +26,74 @@ constexpr unsigned long long ULLONG_MAX = ~0ULL;
 
 template <class T> class numeric_limits {
 public:
-  static constexpr T max();
-  static constexpr T min();
+  LIBC_INLINE static constexpr T max();
+  LIBC_INLINE static constexpr T min();
 };
 
 // TODO: Add numeric_limits specializations as needed for new types.
 
 template <> class numeric_limits<int> {
 public:
-  static constexpr int max() { return INT_MAX; }
-  static constexpr int min() { return INT_MIN; }
+  LIBC_INLINE static constexpr int max() { return INT_MAX; }
----------------
frobtech wrote:

This is a fundamental misunderstanding of the purpose of `LIBC_INLINE`.  It is never implicit, because it exists to be (sometimes) defined to something other than simply `inline`.

https://github.com/llvm/llvm-project/pull/73659


More information about the libc-commits mailing list