[libc-commits] [libc] [libc][NFC] fix int warnings in float conversion (PR #74379)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Mon Dec 4 14:42:21 PST 2023


================
@@ -121,6 +121,7 @@ template <size_t Bits, bool Signed> struct BigInt {
         return lo;
       }
     } else {
+      // TODO: silence shift warning
----------------
nickdesaulniers wrote:

I guess Bits could be a value like 65, hence the warning?  Maybe

```c
if constexpr (Bits == 32) {
  return static_cast<T>((static_cast<T>(val[1]) << 64) + lo);
} else {
  ...
```
would silence the warning?

https://github.com/llvm/llvm-project/pull/74379


More information about the libc-commits mailing list