[libc-commits] [libc] 6886a52 - Revert "[libc] build with -Werror (#73966)"

[Nick Desaulniers via libc-commits]

Author: Nick Desaulniers
Date: 2023-12-04T11:31:59-08:00
New Revision: 6886a52d6dbefff77f33de12ff85d654e2557f81

URL: https://github.com/llvm/llvm-project/commit/6886a52d6dbefff77f33de12ff85d654e2557f81
DIFF: https://github.com/llvm/llvm-project/commit/6886a52d6dbefff77f33de12ff85d654e2557f81.diff

LOG: Revert "[libc] build with -Werror (#73966)"

This reverts commit 606653091d1a66d1a83a1bfdea2883cc8d46687e.

Post submit buildbots are now red. We can use these explicit errors to better
clean up existing warnings, then reland this.

Link: #73966

Added: 
    

Modified: 
    libc/cmake/modules/LLVMLibCObjectRules.cmake
    libc/docs/dev/code_style.rst

Removed: 
    


################################################################################
diff  --git a/libc/cmake/modules/LLVMLibCObjectRules.cmake b/libc/cmake/modules/LLVMLibCObjectRules.cmake
index ef654bd7b34ab..5fbbfd58db2d0 100644
--- a/libc/cmake/modules/LLVMLibCObjectRules.cmake
+++ b/libc/cmake/modules/LLVMLibCObjectRules.cmake
@@ -43,10 +43,6 @@ function(_get_common_compile_options output_var flags)
     list(APPEND compile_options "-fno-rtti")
     list(APPEND compile_options "-Wall")
     list(APPEND compile_options "-Wextra")
-    # -DLIBC_WNO_ERROR=ON if you can't build cleanly with -Werror.
-    if(NOT LIBC_WNO_ERROR)
-      list(APPEND compile_options "-Werror")
-    endif()
     list(APPEND compile_options "-Wconversion")
     list(APPEND compile_options "-Wno-sign-conversion")
     list(APPEND compile_options "-Wimplicit-fallthrough")

diff  --git a/libc/docs/dev/code_style.rst b/libc/docs/dev/code_style.rst
index eeeced0359adb..a050a4c1d3dd7 100644
--- a/libc/docs/dev/code_style.rst
+++ b/libc/docs/dev/code_style.rst
@@ -178,11 +178,3 @@ these functions do not call the constructors and destructors of the
 allocated/deallocated objects. So, use these functions carefully and only
 when it is absolutely clear that constructor and destructor invocation is
 not required.
-
-Warnings in sources
-===================
-
-We expect contributions to be free of warnings from the `minimum supported
-compiler versions`__ (and newer).
-
-.. __: https://libc.llvm.org/compiler_support.html#minimum-supported-versions