[libc-commits] [PATCH] D159112: [libc] POC for namespace customization

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/CMakeLists.txt:68
+if(LLVM_COMPILER_IS_GCC_COMPATIBLE)
+  add_definitions("-DLIBC_NAMESPACE=${LLVM_LIBC_NAMESPACE}")
+elseif(MSVC)
----------------
sivachandra wrote:
> If we use `add_definitions`, we shouldn't use `-D` or the `/D` syntax. CMake will use the appropriate way to add a macro-def based on the compiler we use.
I think I am wrong here. Scrub this!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159112/new/

https://reviews.llvm.org/D159112