[libc-commits] [PATCH] D159296: [libc] Support 'assert.h' on the GPU

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

Did you move the generic `__assert_fail.cpp` file?

In D159296#4632014 <https://reviews.llvm.org/D159296#4632014>, @jhuber6 wrote:

> In D159296#4631913 <https://reviews.llvm.org/D159296#4631913>, @JonChesterfield wrote:
>
>> I don't think the multiple writes to stderr in the normal implementation is an inherently good feature, how about we change the assert implementation on all platforms to compose a single write to stderr?
>
> It'd probably still be sufficiently different because of the warp level operations. I'll leave it to @sivachandra if he wants single printer semantics for this.

I will change it separate from this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159296/new/

https://reviews.llvm.org/D159296