[libc-commits] [PATCH] D159158: [libc] Add a JSON based config option system.

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/CMakeLists.txt:116
+    set(temp ${${opt_name}})
+    unset(${opt_name} CACHE)
+    set(${opt_name} ${temp})
----------------
phosek wrote:
> What's the reason for removing the variable from cache?
I think you saw the previous version which had those commands. I put them in to debug but are removed in the latest version.


================
Comment at: libc/cmake/modules/LibcConfig.cmake:122
+      if(${optname_exists} GREATER -1)
+        # This option is not be overriden so just skip further processing.
+        continue()
----------------
gchatelet wrote:
> ?
Didn't understand :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159158/new/

https://reviews.llvm.org/D159158