[libc-commits] [PATCH] D159276: [libc][gpu] Thread divergence fix on volta

[Joseph Huber via Phabricator via libc-commits]

jhuber6 accepted this revision.
jhuber6 added a comment.
This revision is now accepted and ready to land.

LG With nits.



================
Comment at: libc/src/__support/GPU/amdgpu/utils.h:128-130
+[[clang::convergent]] LIBC_INLINE uint32_t broadcast_value(uint64_t lane_mask,
+                                                           uint32_t x) {
+  (void)lane_mask;
----------------
You can just leave out the argument, same below.


================
Comment at: libc/src/__support/GPU/nvptx/utils.h:127
 [[clang::convergent]] LIBC_INLINE uint64_t ballot(uint64_t lane_mask, bool x) {
+  uint32_t mask = static_cast<uint32_t>(lane_mask);
 #if __CUDA_ARCH__ >= 600
----------------
Unrelated?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159276/new/

https://reviews.llvm.org/D159276