[libc-commits] [PATCH] D159158: [libc] Add a JSON based config option system.

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet added inline comments.


================
Comment at: libc/cmake/modules/LibcConfig.cmake:26
+# command.
+# This function does nothign if |config_file| is missing.
+function(read_libc_config config_file opt_list)
----------------
typo


================
Comment at: libc/cmake/modules/LibcConfig.cmake:101
+# Loads the config options listed in |config_file| in the following way:
+# * For each option listed in the |config_file|, it looks for existance of a
+#   var with the same name. It is an error if the var is not already defined.
----------------
typo `existence`


================
Comment at: libc/cmake/modules/LibcConfig.cmake:103
+#   var with the same name. It is an error if the var is not already defined.
+#   If a var with the option name is found, then it's value is overwritten
+#   with the value specified in |config_file|.
----------------
`its`


================
Comment at: libc/cmake/modules/LibcConfig.cmake:122
+      if(${optname_exists} GREATER -1)
+        # This option is not be overriden so just skip further processing.
+        continue()
----------------
?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159158/new/

https://reviews.llvm.org/D159158