[libc-commits] [PATCH] D159208: [libc] Unify lseek implementations

Mikhail Ramalho via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Aug 30 07:56:01 PDT 2023


mikhail.ramalho created this revision.
mikhail.ramalho added reviewers: sivachandra, michaelrj.
Herald added subscribers: libc-commits, asb.
Herald added projects: libc-project, All.
mikhail.ramalho requested review of this revision.

In patch D157792 <https://reviews.llvm.org/D157792>, the calls to SYS_llseek/SYS_llseek for 32-bit systems
were fixed in lseek.cpp but there was another implementation in file.cpp
that was missed.

To reduce the code duplication, this patch unifies both call sites to
use a new lseekimpl function.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D159208

Files:
  libc/src/__support/File/linux/file.cpp
  libc/src/__support/File/lseekImpl.h
  libc/src/unistd/linux/lseek.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D159208.554726.patch
Type: text/x-patch
Size: 5345 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230830/fc28b4d1/attachment.bin>


More information about the libc-commits mailing list