[libc-commits] [PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

[Louis Dionne via Phabricator via libc-commits]

ldionne marked an inline comment as done.
ldionne added inline comments.


================
Comment at: .ci/generate-buildkite-pipeline-premerge:163
+
+if [[ ! ${SPECIFIC_PIPELINE_AVAILABLE} -eq 1 ]]; then
+  # Figure out which projects need to be built on each platform
----------------
goncharov wrote:
> ldionne wrote:
> > goncharov wrote:
> > > do I understand correctly that if mlir and libcxx modified then only libcxx will be run as SPECIFIC_PIPELINE_AVAILABLE=1?
> > Yes. This corresponds to the current logic as well. Basically if a project has some custom CI set up, we don't want to also run the general CI since that's just a waste of resources.
> The previous logic was that we caclulated first all projects that might be affected by current set (e.g. mlir is affected by llvm), then we added add dependencies.
> So e.g. if mlir was modified, we should add "flang" to test set and then add "llvm clang" as dependincies, resutling in "mlir flang llvm clang" set. I can re-implement this logic later here no problem.
> Also, it seems incorrect to only run "libc++" tests if libc++ was modified among other things. E.g. if something has touched libc++ and mlir than mlir should still run.
Ah, I see. Yeah I guess that makes sense. I'll update this review with the updated logic.

> Also, it seems incorrect to only run "libc++" tests if libc++ was modified among other things. E.g. if something has touched libc++ and mlir than mlir should still run.

You're right, I guess in that case we should run both jobs. I'll remove the check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158863/new/

https://reviews.llvm.org/D158863