[libc-commits] [libc] ba77c16 - [libc] Add more test cases to the argument list tests

[Joseph Huber via libc-commits]

Author: Joseph Huber
Date: 2023-08-28T12:15:29-05:00
New Revision: ba77c160aada87af42d2ec41b0d1ab0ae242cb80

URL: https://github.com/llvm/llvm-project/commit/ba77c160aada87af42d2ec41b0d1ab0ae242cb80
DIFF: https://github.com/llvm/llvm-project/commit/ba77c160aada87af42d2ec41b0d1ab0ae242cb80.diff

LOG: [libc] Add more test cases to the argument list tests

This patch adds some extra cases to the existing argument list test in
`libc`, mainly dealing with arguments of varying sizes and primitive
types.

The purpose of this patch is to provide a wider test area when we begin
to provide varargs support on the GPU as there is no other runtime code
that really tests it. So, running these tests more exhaustively in the
GPU libc project will serve as the runtime tests for GPU vararg support in
D158246.

Reviewed By: sivachandra

Differential Revision: https://reviews.llvm.org/D158867

Added: 
    

Modified: 
    libc/src/__support/macros/config.h
    libc/test/src/__support/arg_list_test.cpp

Removed: 
    


################################################################################
diff  --git a/libc/src/__support/macros/config.h b/libc/src/__support/macros/config.h
index dcc4a3086fb68a..43e81363c1b20b 100644
--- a/libc/src/__support/macros/config.h
+++ b/libc/src/__support/macros/config.h
@@ -39,4 +39,12 @@
 #define LIBC_HAS_FEATURE(f) 0
 #endif
 
+// Compiler attribute-detection.
+// https://clang.llvm.org/docs/LanguageExtensions.html#has-attribute
+#ifdef __has_attribute
+#define LIBC_HAS_ATTRIBUTE(f) __has_attribute(f)
+#else
+#define LIBC_HAS_ATTRIBUTE(f) 0
+#endif
+
 #endif // LLVM_LIBC_SUPPORT_MACROS_CONFIG_H

diff  --git a/libc/test/src/__support/arg_list_test.cpp b/libc/test/src/__support/arg_list_test.cpp
index b8cbcbeb640703..f266ccfdd1ff68 100644
--- a/libc/test/src/__support/arg_list_test.cpp
+++ b/libc/test/src/__support/arg_list_test.cpp
@@ -56,3 +56,97 @@ TEST(LlvmLibcArgListTest, CopyConstructor) {
   ASSERT_EQ(sum_two_nums(3, 5, 1, 2, 4, 8, 16, 32, 64, 128, 256, 512, 1024),
             40);
 }
+
+long int check_primitives(int first, ...) {
+  va_list vlist;
+  va_start(vlist, first);
+  __llvm_libc::internal::ArgList args(vlist);
+  va_end(vlist);
+
+  long int count = 0;
+  count += args.next_var<int>();
+  count += args.next_var<int>();
+  count += args.next_var<int>();
+  count += args.next_var<long>();
+  count += args.next_var<unsigned long>();
+  count += args.next_var<long long>();
+  count += args.next_var<unsigned long long>();
+  count += args.next_var<double>();
+  count += args.next_var<double>();
+  count += args.next_var<long double>();
+  count += *args.next_var<int *>();
+  return count;
+}
+
+TEST(LlvmLibcArgListTest, TestPrimitiveTypes) {
+  char c = '\x01';
+  short s = 2;
+  int i = 3;
+  long l = 4l;
+  unsigned long ul = 5ul;
+  long long ll = 6ll;
+  unsigned long long ull = 7ull;
+  float f = 8.0f;
+  double d = 9.0;
+  long double ld = 10.0L;
+  long v = 11;
+  void *p = &v;
+  ASSERT_EQ(check_primitives(0, c, s, i, l, ul, ll, ull, f, d, ld, p), 66l);
+}
+
+struct S {
+  char c;
+  short s;
+  int i;
+  long l;
+  float f;
+  double d;
+};
+
+long int check_struct_type(int first, ...) {
+  va_list vlist;
+  va_start(vlist, first);
+  __llvm_libc::internal::ArgList args(vlist);
+  va_end(vlist);
+
+  S s = args.next_var<S>();
+  int last = args.next_var<int>();
+  return s.c + s.s + s.i + s.l + s.f + s.d + last;
+}
+
+TEST(LlvmLibcArgListTest, TestStructTypes) {
+  S s{'\x1', 2, 3, 4l, 5.0f, 6.0};
+  ASSERT_EQ(check_struct_type(0, s, 1), 22l);
+}
+
+// Test vector extensions from clang.
+#if LIBC_HAS_ATTRIBUTE(ext_vector_type)
+
+using int1 = int __attribute__((ext_vector_type(1)));
+using int2 = int __attribute__((ext_vector_type(2)));
+using int3 = int __attribute__((ext_vector_type(3)));
+using int4 = int __attribute__((ext_vector_type(4)));
+
+int check_vector_type(int first, ...) {
+  va_list vlist;
+  va_start(vlist, first);
+  __llvm_libc::internal::ArgList args(vlist);
+  va_end(vlist);
+
+  int1 v1 = args.next_var<int1>();
+  int2 v2 = args.next_var<int2>();
+  int3 v3 = args.next_var<int3>();
+  int4 v4 = args.next_var<int4>();
+
+  return v1.x + v2.x + v2.y + v3.x + v3.y + v3.z + v4.x + v4.y + v4.z + v4.w;
+}
+
+TEST(LlvmLibcArgListTest, TestVectorTypes) {
+  int1 v1 = {1};
+  int2 v2 = {1, 2};
+  int3 v3 = {1, 2, 3};
+  int4 v4 = {1, 2, 3, 4};
+  ASSERT_EQ(check_vector_type(0, v1, v2, v3, v4), 20);
+}
+
+#endif