[libc-commits] [PATCH] D158867: [libc] Add more test cases to the argument list tests

[Joseph Huber via Phabricator via libc-commits]

jhuber6 added inline comments.


================
Comment at: libc/src/__support/macros/config.h:44
+// https://clang.llvm.org/docs/LanguageExtensions.html#has-attribute
+#ifdef __has_feature
+#define LIBC_HAS_ATTRIBUTE(f) __has_attribute(f)
----------------
sivachandra wrote:
> `s/__has_feature/__has_attribute`
Whoops, thanks for catching that.


================
Comment at: libc/test/src/__support/arg_list_test.cpp:90
+  size_t st = 7ll;
+  ptrdiff_t pt = 8ll;
+  float f = 9.0f;
----------------
sivachandra wrote:
> Can we avoid non-primitives and just stick to primitives here? For example, instead of `intmax_t`, `size_t` and `ptrdiff_t`, add `unsigned short` etc? Then, we don't have to worry about platforms where `size_t` is not `long long` etc.
Will do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158867/new/

https://reviews.llvm.org/D158867