[libc-commits] [PATCH] D158867: [libc] Add more test cases to the argument list tests

[Joseph Huber via Phabricator via libc-commits]

jhuber6 added inline comments.


================
Comment at: libc/test/src/__support/arg_list_test.cpp:134
+  va_start(vlist, first);
+  __llvm_libc::internal::ArgList args(vlist);
+  va_end(vlist);
----------------
JonChesterfield wrote:
> Does this call va_copy on the argument? I.e. is va_end immediately after making one the safe thing to do, even if va_end is not a no-op?
Yes, it `va_copy`'s it for the constructor. I think there's an explicit test for that in this file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158867/new/

https://reviews.llvm.org/D158867