[libc-commits] [PATCH] D158867: [libc] Add more test cases to the argument list tests

[Joseph Huber via Phabricator via libc-commits]

jhuber6 added inline comments.


================
Comment at: libc/test/src/__support/arg_list_test.cpp:77
+  count += args.next_var<double>();
+  count += args.next_var<long>();
+  if (args.next_var<void *>() != nullptr)
----------------
arsenm wrote:
> jhuber6 wrote:
> > arsenm wrote:
> > > jhuber6 wrote:
> > > > arsenm wrote:
> > > > > Also should test short, half, pointers, ext_vector_type, bool
> > > > Would `ext_vector_type` compile on the GPU?
> > > well it's all the vector types. that's what opencl vectors are and work
> > Can you provide an example of that? I assume `ext_vector_specific` is an OpenCL term that might has some other way to use externally like a lot of other things. This test should primarily work on X64 but we can use macros to only enable a test for the GPU if needed (though it won't do anything right now).
> No, it's the clang extension used to implement opencl, just through typedefs. e.g.
> 
> ```
> typedef int int4 __attribute__((ext_vector_type(4)));
> ```
Seems that's a clang extension, so we'll probably need to guard it somehow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158867/new/

https://reviews.llvm.org/D158867