[libc-commits] [PATCH] D158867: [libc] Add more test cases to the argument list tests

[Joseph Huber via Phabricator via libc-commits]

jhuber6 added inline comments.


================
Comment at: libc/test/src/__support/arg_list_test.cpp:67
+  long int count = 0;
+  count += args.next_var<int>();
+  count += args.next_var<int>();
----------------
arsenm wrote:
> no char either?
It's passed in as a char, but all varargs get promoted to an integer as far as I'm aware, https://godbolt.org/z/Wssrrz3M1.


================
Comment at: libc/test/src/__support/arg_list_test.cpp:77
+  count += args.next_var<double>();
+  count += args.next_var<long>();
+  if (args.next_var<void *>() != nullptr)
----------------
arsenm wrote:
> Also should test short, half, pointers, ext_vector_type, bool
Would `ext_vector_type` compile on the GPU?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158867/new/

https://reviews.llvm.org/D158867