[libc-commits] [PATCH] D158633: [libc] Remove `MAX_LANE_SIZE` definition from the RPC server
Joseph Huber via Phabricator via libc-commits
libc-commits at lists.llvm.org
Wed Aug 23 09:59:19 PDT 2023
jhuber6 added inline comments.
================
Comment at: libc/utils/gpu/server/rpc_server.cpp:96
std::memcpy(buffer->data, &ret, sizeof(uint64_t));
+ delete[] reinterpret_cast<uint8_t *>(strs[id]);
});
----------------
JonChesterfield wrote:
> Was a functional change intended here?
This isn't technically a functional change, since this callback automatically uses the current thread mask I could put this part in here instead which serves the purpose of getting rid of the invocation of the lane size.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158633/new/
https://reviews.llvm.org/D158633
More information about the libc-commits
mailing list