[libc-commits] [PATCH] D158633: [libc] Remove `MAX_LANE_SIZE` definition from the RPC server

[Jon Chesterfield via Phabricator via libc-commits]

JonChesterfield added a comment.

I'm not sure about this being on the methods. Why not the class itself? We have a bad time if different places manage to disagree on the value



================
Comment at: libc/utils/gpu/loader/Loader.h:113
   // Register the ping test for the `libc` tests.
   rpc_register_callback(
       device_id, static_cast<rpc_opcode_t>(RPC_TEST_INCREMENT),
----------------
Static assert that it's 32 or 64 here, or maybe go so far as a valid-for-target call?


================
Comment at: libc/utils/gpu/loader/amdgpu/Loader.cpp:425
 
+  // Register RPC callbacks for the malloc and free functions on HSA.
+  if (wavefront_size == 32)
----------------
handle_error if it isn't 32 or 64 please. Maybe a switch on size with handle_error in the default?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158633/new/

https://reviews.llvm.org/D158633