[libc-commits] [PATCH] D158447: [libc] Add the 'cpp.new' as a dependency on `atexit`

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Aug 21 12:57:22 PDT 2023


jhuber6 created this revision.
jhuber6 added reviewers: sivachandra, lntue, michaelrj.
Herald added projects: libc-project, All.
Herald added a subscriber: libc-commits.
jhuber6 requested review of this revision.

The `atexit` function depends on the implementations in CPP/new.h but it
is not listed as a dependency. This causes the GPU build to not include
it in the `libcgpu.a` file and prevents us from using the startup code
externally. Simply add it.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D158447

Files:
  libc/src/stdlib/CMakeLists.txt


Index: libc/src/stdlib/CMakeLists.txt
===================================================================
--- libc/src/stdlib/CMakeLists.txt
+++ libc/src/stdlib/CMakeLists.txt
@@ -366,6 +366,7 @@
     libc.src.__support.fixedvector
     libc.src.__support.blockstore
     libc.src.__support.threads.mutex
+    libc.src.__support.CPP.new
 )
 
 add_entrypoint_object(


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158447.552110.patch
Type: text/x-patch
Size: 366 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230821/079a413e/attachment.bin>


More information about the libc-commits mailing list