[libc-commits] [PATCH] D158435: [libc] Configure the 'printf' implementation for the GPU

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Aug 21 09:28:13 PDT 2023


jhuber6 added a comment.

In D158435#4603994 <https://reviews.llvm.org/D158435#4603994>, @JonChesterfield wrote:

> Can we do the long double part in the source?
>
> I'm thinking that lots of targets have double and long double as the same type, so we should be able to branch at compile time to cast long double to double and go through the double code path instead

I brought that up with @michaelrj previously. The GPU build already sets a macro in `libc` called `LONG_DOUBLE_IS_DOUBLE` which should also disable the massive long double table. He said he'd work on it, but in general we should probably configure the other stuff anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158435/new/

https://reviews.llvm.org/D158435



More information about the libc-commits mailing list