[libc-commits] [PATCH] D158246: [amdgpu] WIP variadics

[Matt Arsenault via Phabricator via libc-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/DesugarVariadics.cpp:208-209
+
+    StructType *VarargsTy = StructType::create(
+        Ctx, LocalVarTypes, (Twine(NF->getName()) + ".vararg").str());
+
----------------
Should we go for a packed struct forced to align 4? There's no upside to stack values with > 4 align


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158246/new/

https://reviews.llvm.org/D158246