[libc-commits] [PATCH] D158033: [libc][NFC] Add new is_trivially_destructible check to libc's type_traits

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Aug 18 12:25:55 PDT 2023


jhuber6 added a comment.

In D158033#4599844 <https://reviews.llvm.org/D158033#4599844>, @sivachandra wrote:

> In D158033#4599842 <https://reviews.llvm.org/D158033#4599842>, @jhuber6 wrote:
>
>> This file is compiled with the system GCC which is version 9.4.
>
> The official supported minimum GCC version is 12.2: https://libc.llvm.org/compiler_support.html

So this differs from the LLVM requirement? That's problematic for this particular file because it's expected to be compiled with the user's configuration since it implements the CPU side server to interface with the RPC server. The GPU portion is only compiled with just-built clang. So it'll end up that  the files I'm including there need to at least be able to be compiled. Any way we could make these statically return false in this case? I'm assuming it won't negatively impact anything else considienrg they're already guarded by `__has_builtin`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158033/new/

https://reviews.llvm.org/D158033



More information about the libc-commits mailing list