[libc-commits] [PATCH] D158213: [libc] Do not run tests on vendor implemented math

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Aug 17 13:42:20 PDT 2023


jhuber6 created this revision.
jhuber6 added reviewers: sivachandra, lntue, michaelrj, JonChesterfield, jdoerfert.
Herald added projects: libc-project, All.
Herald added a subscriber: libc-commits.
jhuber6 requested review of this revision.

We currently remap vendor implementations of math functions to provide a
temporarily functional `libm.a` for the GPU. However, we should not run
tests on any files that depend on these vendor implementations as they
are not under our control and are not always present.

The goal in the future is to remove the need for this by replacing all
the vendor functionality, but for now this is a workaround.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D158213

Files:
  libc/cmake/modules/LLVMLibCLibraryRules.cmake
  libc/cmake/modules/LLVMLibCObjectRules.cmake
  libc/cmake/modules/LLVMLibCTestRules.cmake
  libc/src/math/CMakeLists.txt
  libc/src/math/gpu/CMakeLists.txt
  libc/src/math/gpu/vendor/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D158213.551252.patch
Type: text/x-patch
Size: 4876 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230817/69441858/attachment.bin>


More information about the libc-commits mailing list