[libc-commits] [PATCH] D158203: [libc] Do not find system binaries for offloading tools

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Aug 17 11:44:56 PDT 2023


jhuber6 added a comment.

In D158203#4596300 <https://reviews.llvm.org/D158203#4596300>, @arsenm wrote:

> In D158203#4596291 <https://reviews.llvm.org/D158203#4596291>, @jhuber6 wrote:
>
>> In D158203#4596285 <https://reviews.llvm.org/D158203#4596285>, @arsenm wrote:
>>
>>> Can this try to use the imported target instead of searching
>>
>> So this is part of the `runtimes` which is a separate cmake job so it doesn't share the targets.
>
> I'd still hope the runtimes build would use exported targets for these sorts of tools

I'm not very familiar with that, do we export tools in this way? I thought it was all just binaries in a directory once you leave the main CMake invocation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158203/new/

https://reviews.llvm.org/D158203



More information about the libc-commits mailing list