[libc-commits] [PATCH] D158033: [libc][NFC] Add new is_trivially_destructible check to libc's type_traits
Siva Chandra via Phabricator via libc-commits
libc-commits at lists.llvm.org
Wed Aug 16 14:13:20 PDT 2023
sivachandra accepted this revision.
sivachandra added a comment.
Apart from the nit, rest LGTM.
================
Comment at: libc/src/__support/CPP/type_traits.h:289
+
+template <typename> struct __is_destructible_apply {
+ typedef int type;
----------------
Internal types have been listed in nested namespace named `details` in this file. So, you should follow that convention.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158033/new/
https://reviews.llvm.org/D158033
More information about the libc-commits
mailing list