[libc-commits] [PATCH] D157156: [libc] Add get_explicit_exponent to fpbits

[Tue Ly via Phabricator via libc-commits]

lntue added inline comments.


================
Comment at: libc/src/__support/FPUtil/x86_64/LongDoubleBits.h:150
+    if (is_zero()) {
+      return 0;
+    } else if (unbiased_exp == 0) {
----------------
In most of the conventions for floating point exponents, zeros are often grouped together with denormal numbers.  Unless it's used in more places, do you think the logic that requires different ways of handling exponents of zeros can be put locally to those functions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157156/new/

https://reviews.llvm.org/D157156