[libc-commits] [PATCH] D150211: [libc] Extend optional to support non trivially destructible objects

Mikhail Ramalho via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Aug 11 19:01:13 PDT 2023


mikhail.ramalho marked an inline comment as done.
mikhail.ramalho added a comment.

I've managed to reduce the implementation even further:

- moved the OptionalStorage to inside the class optional, like it was before, but now the partial specialization for trivially destructible objects is there as well.
- removed all value() methods from OptionalStorage() to reduce duplicated code. Now store_value is accessed directly.
- moved in_use to the class optional. It's a private member there now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150211/new/

https://reviews.llvm.org/D150211



More information about the libc-commits mailing list