[libc-commits] [PATCH] D150211: [libc] Extend optional to support non trivially destructible objects
Mikhail Ramalho via Phabricator via libc-commits
libc-commits at lists.llvm.org
Fri Aug 11 16:43:44 PDT 2023
mikhail.ramalho added a comment.
In D150211#4581518 <https://reviews.llvm.org/D150211#4581518>, @michaelrj wrote:
> This patch is looking a lot better. I think it should be good to go after dealing with the structs
I think that was the minimal way of doing it without duplicating the code
but I can do something like the glibc's optional
it has only two classes for the optional, but there is a lot of duplicated code since the only difference between the two classes is the destructor call. See:
https://github.com/gcc-mirror/gcc/blob/fab08d12b40ad637c5a4ce8e026fb43cd3f0fad1/libstdc%2B%2B-v3/include/experimental/optional#L136
https://github.com/gcc-mirror/gcc/blob/fab08d12b40ad637c5a4ce8e026fb43cd3f0fad1/libstdc%2B%2B-v3/include/experimental/optional#L278
the only difference between these two classes is:
https://github.com/gcc-mirror/gcc/blob/fab08d12b40ad637c5a4ce8e026fb43cd3f0fad1/libstdc%2B%2B-v3/include/experimental/optional#L353
WDYT?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150211/new/
https://reviews.llvm.org/D150211
More information about the libc-commits
mailing list